Changeset f25df21 for dict.c

Timestamp:

Mar 24, 2011, 4:05:29 PM (13 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

c809f5e

Parents:

e56303f

git-author:

David Benjamin <davidben@mit.edu> (03/08/11 15:04:52)

git-committer:

David Benjamin <davidben@mit.edu> (03/24/11 16:05:29)

Message:

Don't call owl_list_create in owl_dict_get_keys

Until we get rid of this owl_list thing altogether, there should be a
convention as to who initializes the thing. Otherwise, we leak memory
from people initializing it too many times.

Whoever reviews this probably wants to look over this very carefully in
case I missed one of the owl_list_creates.

Also kill the various wrappers over owl_list_cleanup as they are not the
inverse of any operation.

File:

• dict.c (modified) (1 diff)

dict.c

@@ -58 +58 @@
 }
 
-/* creates a list and fills it in with keys.  duplicates the keys, 
+/* Appends dictionary keys to a list.  Duplicates the keys,
  * so they will need to be freed by the caller. */
 int owl_dict_get_keys(const owl_dict *d, owl_list *l) {
   int i;
   char *dupk;
-  if (owl_list_create(l)) return(-1);
   for (i=0; i<d->size; i++) {
     if ((dupk = g_strdup(d->els[i].k)) == NULL) return(-1);