Opened 5 years ago

Closed 5 years ago

#289 closed defect (fixed)

warning: implicit declaration of function ‘strchrnul’ in zephyr.c

Reported by: jgross@mit.edu Owned by:
Priority: minor Milestone:
Component: internals Keywords: clang build
Cc: jgross@mit.edu

Description

Clang warns us that

../zephyr.c: In function ‘owl_zephyr_smartstripped_user’:

../zephyr.c:1313:3: warning: implicit declaration of function ‘strchrnul’ [-Wimplicit-function-declaration]

../zephyr.c:1313:17: warning: initialization makes pointer from integer without a cast [enabled by default]

According to strchrnul(3), we need to define _GNU_SOURCE. Where should this go? (Makefile.am? configure.ac?) Googling configure.ac strchrnul gives more verbose suggestions, such as including our own implementation of strchrnul for platforms that lack it, like FreeBSD. What do we want to do?

Change History (2)

comment:1 Changed 5 years ago by andersk@mit.edu

BarnOwl shouldn’t rely on GNU extensions, so I removed strchrnul in PR 171 (ff5823998a76c312dd317962e065c9f23c8cb457).

comment:2 Changed 5 years ago by andersk@mit.edu

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.