Changeset 44a61ac for zwrite.c

Timestamp:

Feb 11, 2009, 12:20:21 PM (16 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

2101a50

Parents:

8412869

git-author:

Nelson Elhage <nelhage@mit.edu> (02/08/09 20:07:00)

git-committer:

Nelson Elhage <nelhage@mit.edu> (02/11/09 12:20:21)

Message:

zwrite.c: Fix an unsafe use of sprintf.

Reported-By: Geoffrey Thomas <geofft@mit.edu>

File:

• zwrite.c (modified) (2 diffs)

zwrite.c

@@ -195 +195 @@
 {
   int i, j;
-  char to[LINE];
+  char *to;
 
   if (z->noping) return;
@@ -209 +209 @@
   for (i=0; i<j; i++) {
     if (strcmp(z->realm, "")) {
-      sprintf(to, "%s@%s", (char *) owl_list_get_element(&(z->recips), i), z->realm);
+      to = owl_sprintf("%s@%s", (char *) owl_list_get_element(&(z->recips), i), z->realm);
     } else {
-      strcpy(to, owl_list_get_element(&(z->recips), i));
+      to = owl_strdup(owl_list_get_element(&(z->recips), i));
     }
     send_ping(to);
+    owl_free(to);
   }