smartnarrow does not always do what I want with un and .d

[kchen@MIT.EDU]

When I press M-n or M-N, sometimes I want un and .d classes to be included, and sometimes I don't. While I can work around this by manually specifying a filter with view -d, it would be convenient to have a quick way of narrowing to a class or instance, sometimes with the un and .d, and sometimes without.

Relatedly, if I specify :viewclass classname (or :viewclass unclassname), I generally do want just the specified class, not everything else.

[nelhage@MIT.EDU]

I'd believe :viewclass should just always treat its argument literally -- do people agree with that sentiment?

I think I'd propose to keep M-n and M-N as is, but make :viewclass treat its argument literally, and accept a second argument that is an optional instance to narrow to. Potentially it could also accept an optional flag so that, e.g. viewclass -u included unclasses.

Thoughts from anyone else?

[geofft@MIT.EDU]

I suggested making a M-m and M-M for "modified smartnarrow", and having a toggle to define which one is "normal" and which is "modified".

[nelhage@mit.edu]

I'm milestoning this for 1.6, since geofft has code and it's dumb that we've been letting wanking about the UI and naming issue block us from fixing a real bug. I'll follow up on-list.

[nelhage@mit.edu]

Merged geofft's modnarrow under a different name. M-m and M-M now do the inverse of the default, and the 'narrow-related' variable controls the default.