Timeline


and

Sep 30, 2010:

8:07 PM Changeset [385cce2]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove the DESTROY hook in MainLoopCompatHook It can't cause a timer leak and is causing spew in tests.
8:07 PM Changeset [ac6d4e4]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Cache the current column to avoid repeatly recomputing it In particular, we appropriately update it when inserting characters.
8:07 PM Changeset [9c3f334]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
cursorx in oe_insert_char is a lie There's even a comment to that effect. Use owl_editwin_current_column instead. This fixes the previously checked-in unit test.
8:07 PM Changeset [58a16cc]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add a unit test for the editwin's automatic wrapping Currently fails because the wrapping doesn't happen.
8:07 PM Changeset [52172cc]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Update the editwin's fillcol and wrapcol on resize Otherwise resizing the window during the lifetime of an editwin will not pick up changes.
8:07 PM Changeset [e75a6df]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Document oe_find_display_line It took me a few readings before figuring out what it does.

Sep 25, 2010:

10:26 PM Changeset [c8d9f84]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
More aggressively stop Timers created in perl In case something leaks with references or whatever, at least we don't leak timers.
5:58 PM Changeset [b120bd3]release-1.10release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
add a random zsig function
1:19 AM Ticket #85 (incorporate Twitter functionality into main owl distribution) closed by davidben@mit.edu
fixed: I'm going to close this since the Twitter module's been merged into …
12:44 AM Ticket #144 (Need better notification when sending a zephyr fails) closed by davidben@mit.edu
fixed: Fixed in 0743696d205f89f0d3f9cd064a75fdedb9269b89
12:39 AM Ticket #48 (barnowl should allow searching in popups) closed by davidben@mit.edu
fixed: And the branch has been merged.

Sep 22, 2010:

4:00 PM Ticket #30 (Jabber reply-to-sender fails to quote spaces in sender name) closed by davidben@mit.edu
fixed: Looks like this was fixed in 680ada9ec54138d0477bb53981a916c0fede159f.

Sep 21, 2010:

5:33 PM Changeset [118c919]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Name search argument consider_current Adding yet another enum for a boolean value is overkill.

Sep 18, 2010:

5:07 PM Changeset [4a41f16]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Pass deactivate_cb as argument to owl_editcontext_new
5:07 PM Changeset [1b8c3f8]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
owl_viewwin doesn't need to keep track of cmdline
5:07 PM Changeset [dcd48ad]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Disable, for now, the bindings for popless:start-command They're not very polished, with the contexts and commands situation being so fluid for now.
5:07 PM Changeset [d2fd2f7]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add popless:start-search and bind to / and ? The command line is considerably friendlier when it knows it's searching.
5:07 PM Changeset [b6cf72f]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
FINALLY! Add a popless:search command That took a while.
5:07 PM Changeset [9c1e61d4]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add OWL_SEARCH_CONTINUE and OWL_SEARCH_MATCH_CURRENT Instead of having a confusing mode argument, define more constants.
5:07 PM Changeset [a728387]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Just remove owl_function_search_{start,continue} altogether There's only one caller, and they're (now) tiny. We may as well just inline them.
5:07 PM Changeset [2ec737f]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add owl_function_set_search Instead of allowing OWL_DIRECTION_NONE in owl_function_search_start, make the setsearch command just call a more approriately named function. Also, move the mainwin redisplay into owl_global_set_search_re. Although, really it should just emit a signal.
5:07 PM Changeset [09ceee3]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add a command-line to the viewwin It's triggered via popless:start-command.
5:07 PM Changeset [4811422]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Delay realizing a window until we need it for painting This avoids WINDOW churn if we show and hide windows a lot.
5:07 PM Changeset [5f0bcde]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make the check for _owl_window_realize more readable
5:07 PM Changeset [38e2250]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use bool instead of int in owl_window
5:07 PM Changeset [6a35938]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add an unspeakably ugly version of reverse search I think we really want the viewwin to have pre-split the output into lines.
5:07 PM Changeset [fc5eef4]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Configure owl_global_set_typwin_inactive to be called on context deactivate This removes the explicit calls to the deactivate function. In particular, it means that we can set up an alternate deactivate function and edit:done needn't know about it.
5:07 PM Changeset [c394de8]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use ref-counting to make editwin ownership saner When creating an editwin, one creates an editcontext which takes a reference to the editwin. Likewise, the pointer in owl_global holds reference. The reference counting manages their ownership claims. In addition, owl_global_set_typwin_inactive now does release a reference. Instead, the callback-calling commands take a reference and release it later. We may wish to further improve that so that the contexts are also ref-counted such that, when their commands are running, they will not be deallocated, even if popped. That will avoid the callback dance.
5:07 PM Changeset [9190285]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Ref-count the editwin
5:07 PM Changeset [08263a8]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add owl_editwin_get_window This removes the need for owl_global_get_typwin_window. The remaining references within global.c may be accessed directly as its an internal field anyway.
5:07 PM Changeset [cb81570]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add a separate owl_context_new and remove owl_context_init The latter is unused anyway.
5:07 PM Changeset [1d74663]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add deactivate and delete hooks for owl_context Also make pushing and popping slightly more flexible.
5:07 PM Changeset [818f19c]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Rename owl_global_get_typwin to owl_global_current_typwin The new name is more explicitly the currently active typwin.
5:07 PM Changeset [005eae5]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make owl_global_get_typwin return the context's typwin The only remaining callers are the perl glue and some functions in keys.c. This makes that allo of that code independent of a global editwin.
5:07 PM Changeset [a8186dc]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
owl_editwin should own a reference to its window
5:07 PM Changeset [60c1386]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Split the viewwin's status bar into its own window
5:07 PM Changeset [2640b63]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Rearrange some viewwin functions The two constructor should be together. Otherwise, it's a bit hard to read.
5:07 PM Changeset [b8742ba]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add half an implementation of owl_viewwin_search
5:07 PM Changeset [9116936]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Draw ~s in empty viewwin lines, to mimic less
5:07 PM Changeset [fa23002]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Never move the screen up when during an owl_viewwin_down We already can get in such a state, and a searchable popwin will be even easier. Mimic less's behavior here.
5:07 PM Changeset [d574d61]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add owl_viewwin_up and owl_viewwin_down So we have one consistent place for the clipping logic. Also, take BOTTOM_OFFSET into account in owl_viewwin_pageup.
5:07 PM Changeset [9eb38bb]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Likewise, don't reuse a global owl_viewwin This means we don't have to support plugging and unplugging that thing over and over. We also can almost entirely drop the global owl_viewwin. Most of the code gets it from the context anyway.
5:07 PM Changeset [8ee712e0]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Delete the popwin when closing it
5:07 PM Changeset [61c1f19]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't export owl_viewwin_set_window.
5:07 PM Changeset [03ca005]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Create a new owl_popwin every time instead of rewiring the old one Constantly rewiring things is weird.
5:07 PM Changeset [b3b1b05]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
To be thorough, track all signal ids in the popwin This isn't actually necessary here, but it's more correct. The awkwardness suggests that we want the widgets to be GObjects so that owl_signal_connect_object may do this automatically.
3:17 PM Changeset [7ba2ad4]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Implement owl_fmtext_line_extents and add test case
3:17 PM Changeset [4cf7b1b]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
If owl_popwin_up fails, abort the command
3:17 PM Changeset [6425d43]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't cause confusion if owl_popwin_up on an active popwin Likewise, inactive popwins should not be closeable. The function returns int, so we may as well return an error, but no one checks that.
3:17 PM Changeset [dc9665a]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add a test case for owl_fmtext_search
3:17 PM Changeset [f7456bc]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add owl_fmtext_line_number and test.
3:17 PM Changeset [5b68c05]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Update the viewwin when the global search string changes This will want to be made less hacky when we have some notification mechanism for all of owl_global's properties. Also, use the new owl_viewwin_dirty in internal functions to avoid dirtying a NULL window.
3:17 PM Changeset [449c682]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Honor the do_search argument to _owl_fmtext_curs_waddstr It hasn't done anything since 41c9a9675faf455c3c6adfbc629faf55ddbfe10f. This also makes the viewwin explicitly request search highlighting, to preserve old behavior.
3:17 PM Changeset [72f613a]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make owl_fmtext_search take and return an offset
3:14 PM Changeset [9c678a5]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Actually set the context interactive in the startup routine This got lost back in 2a17b635c6895121650446d2529f46d7e291a486.
3:14 PM Changeset [de6f317]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Move zephyr and ncurses shutdown into main They are initialized in main, so they may as well be tore down there. Although, we'll probably want to move both elsewhere sometime.
3:14 PM Changeset [3ecd78b]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Move the event loop to owl_select as owl_select_run_loop Also adds a function to quit the select loop so that owl_function_quit needn't exit() directly. main should be allowed to clean up after itself.
3:14 PM Changeset [8402a093]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Move the error signal logging to a pre_select_action This reduces our event loop to owl_select.

Sep 15, 2010:

7:44 PM const edited by andersk@mit.edu
s/the the/the/ (diff)
12:58 AM Ticket #91 (:startup and wordwrap interact poorly) closed by davidben@mit.edu
fixed: This was fixed in 9d7a7205d6c9cbea0e8999e4c350440f8ef5fef8.
12:47 AM Ticket #148 (misleading text for sender on zwrite to multiple people without -C) closed by davidben@mit.edu
duplicate: This is a duplicate of #63.
12:40 AM Ticket #100 (typewindelta hides status messages) closed by davidben@mit.edu
fixed: This appears fixed in master. I believe some combination of owl_window …
12:35 AM Ticket #68 (hang on searching for a too-long string) closed by davidben@mit.edu
fixed: Should be fixed in 9d7a7205d6c9cbea0e8999e4c350440f8ef5fef8.
12:33 AM Ticket #8 (smartnarrow on CC'd personals should include all people in the CC list) closed by davidben@mit.edu
fixed: This should be fixed in ecaec2163c1c65f306cb1ce7b5c56c3d2c3096ca.

Sep 14, 2010:

11:24 PM Changeset [10dd8e6]release-1.10release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Twitter: Don't attempt to do OAuth against non-twitter.com services.
4:56 PM Changeset [ba042db]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove _owl_panel_set_window It hasn't been used since owl_window.
2:11 AM Changeset [0743696]release-1.10release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't ignore the error code when doing a zwrite Display a com_err-supplied error message. It's about time we fix the false "Waiting for ack..." messages. Also, on an error in a zephyr with multiple recipients, abort instead of continuing to send, to match the zwrite binary.

Sep 11, 2010:

5:25 PM Changeset [f544216]release-1.10release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Fix module-loading priorities. I think we actually get this right, now. Local modules are preferred to system modules, and unpacked modules are preferred to PAR modules in the same directory.

Sep 9, 2010:

1:24 AM Changeset [8106870]release-1.10release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Twitter: BarnOwl::quote the replycmd Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>

Sep 8, 2010:

10:36 PM Changeset [ad7cc2f]release-1.10release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
owl_perlconfig_new_command: Pass G_EVAL. In addition to the obvious bugs this fixes, this prevents us from repeatedly reporting an error if $@ was set at entry to the function.
9:32 PM Changeset [8c6e2c1]release-1.10release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Twitter: Allow users to specify their own consumer key/secret.

Aug 31, 2010:

11:02 AM Changeset [2c5ee3e]release-1.10release-1.7release-1.8release-1.9 by Alejandro R. Sedeño <asedeno@mit.edu>
Don't try to load default subs if zephyr has not been initialized yet. Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
Note: See TracTimeline for information about the timeline view.