Timeline


and

Jul 3, 2011:

11:47 PM Changeset [530c51c] by GitHub Merge Button <merge-button@github.com>
Merge 5c2ef5b8924ebc9e6c3d006f362dde3e73568d68 into 785ee770a72bcdda39fd541a90d8c640fa5c76ca
11:42 PM Changeset [5c2ef5b] by Jason Gross <jgross@mit.edu>
Don't segfault when you expunge all messages from the messagelist When we used owl_list, trying to get an element from an empty list would return NULL. When we moved to GPtrArray, we dropped this checking, without dropping the assumption that, e.g., owl_view_get_element(v, owl_global_get_curmsg(&g)); works everywhere. This commit adds the logic back in to deal with this case. Additionally, don't segfault on things like :unpunt -1.
9:17 PM Ticket #184 (Default zsigs are empty) closed by jgross@mit.edu
fixed: Resolved by ca749a95d6931025b7d334764a6776c9dbf0325d
8:57 PM Changeset [863f4c4] by GitHub Merge Button <merge-button@github.com>
Merge 785ee770a72bcdda39fd541a90d8c640fa5c76ca into 82e93c95ea82cdc4725e91b4d3ac6ac4f0b75f24
8:43 PM Changeset [785ee77]release-1.8release-1.9 by Jason Gross <jgross@mit.edu>
Allow zsigs to be '0' Also, keep the feature that setting the zsig to '' will reset it to the default.
8:43 PM Changeset [fa981f3]release-1.8release-1.9 by Jason Gross <jgross@mit.edu>
Removed some NULL checks for things that really shouldn't ever be NULL If a BarnOwl variable can't be gotten, then something is horribly wrong, and if it can't be gotten as a string, then perl will be confused (and something is probably horribly wrong anyway). Additionally, our variable descriptions shoud be descriptive. Valid settings should not be NULL (and NULL is more likely indicative of forgetting to set it than actually wanting an empty valid set).
8:43 PM Changeset [1dab38e]release-1.8release-1.9 by Jason Gross <jgross@mit.edu>
Make owl_variable_dict_newvar_* give accurate validsettings
8:43 PM Changeset [b4a678a]release-1.8release-1.9 by Jason Gross <jgross@mit.edu>
Added tests to tester.c to make sure that NULL values are gotten appropriately
8:43 PM Changeset [ca749a9]release-1.8release-1.9 by Jason Gross <jgross@mit.edu>
Make variable getters return NULL instead of "<null>" This fixes trac-#184: Since commit 010a9511420887329269aa51e7598533e826c57f, the default zsigs show up as empty; BarnOwl::default_zephyr_signature() checks BarnOwl::getvar('zsigproc') as a boolean (which may be incorrect if you happen to have a zsigproc called 0). As of that commit, BarnOwl::getvar returns "<null>" instead of undef.
8:42 PM Changeset [ca54fd6]release-1.8release-1.9 by Jason Gross <jgross@mit.edu>
Pass owl_variable * around instead of owl_vardict *. This allows (forces) functions to do their own NULL- and type- checking on variables. The functions in varsubs.c get less checking, but if these auto-generated functions are failing, something more serious is probably wrong. The owl_variable_get_* functions type-check their arguments, and owl_function_error if the argument is the wrong type (it's a programmer error and we should make some noise).
8:08 PM Changeset [bc1d648]release-1.8release-1.9 by Jason Gross <jgross@mit.edu>
Drop require_type It's not doing much for us (and would do even less after the next commit). I'm not sure whether or not we should type-check owl_variable_get_*

Jun 30, 2011:

3:16 AM Ticket #187 (The editwin should have (optional) spell check) created by jgross@mit.edu
It would be nice to be able to spell-check my zephyrs from within …

Jun 28, 2011:

1:45 PM Changeset [82e93c9]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
AX_CHECK_FLAG: Fix to work with autoconf 2.59 • AS_VAR_PUSHDEF([FLAGS], [something containing FLAGS]) caused an infinite loop before v2.65~21. • AS_VAR_APPEND was new in v2.63b~224. • AS_VAR_IF was new in v2.63~27. • AS_ECHO was new in AUTOCONF-2.61a~45, and AC_PROG_GREP in AUTOCONF-2.59c~744, but their use here is more idiomatically replaced with a case pattern anyway. • Before AUTOCONF-2.60b~8, the variable name passed to AC_CACHE_CHECK, AS_VAR_GET, AS_VAR_SET, and AS_VAR_SET_IF must be left unquoted. Signed-off-by: Anders Kaseorg <andersk@mit.edu> (cherry picked from autoconf-archive commit f5ed01f0ce1d9b3be7c0cd92db192bf5c44d7fcb)
2:09 AM Ticket #186 (Trac is slow) created by jgross@mit.edu
Login and view tickets are especially slow.

Jun 27, 2011:

1:01 PM Ticket #185 (Barnowl should warn novices that they're not subbed to a triplet ...) created by jdreed@mit.edu
(See also Debathena #938) Every so often, someone will try out zephyr …
4:28 AM Changeset [554787e8] by Jason Gross <jgross@mit.edu>
Added tests to tester.c to make sure that NULL values are gotten appropriately
4:28 AM Changeset [b75a8ac] by Jason Gross <jgross@mit.edu>
Make variable getters return NULL instead of "<null>" This fixes trac-#184: Since commit 010a9511420887329269aa51e7598533e826c57f, the default zsigs show up as empty; BarnOwl::default_zephyr_signature() checks BarnOwl::getvar('zsigproc') as a boolean (which may be incorrect if you happen to have a zsigproc called 0). As of that commit, BarnOwl::getvar returns "<null>" instead of undef.
4:28 AM Changeset [0d935a1] by Jason Gross <jgross@mit.edu>
Pass owl_variable * around instead of owl_vardict *. This allows (forces) functions to do their own NULL- and type- checking on variables. The functions in varsubs.c get less checking, but if these auto-generated functions are failing, something more serious is probably wrong.
4:28 AM Changeset [f4e857f] by Jason Gross <jgross@mit.edu>
Removed some NULL checks for things that really shouldn't ever be NULL If a BarnOwl variable can't be gotten, then something is horribly wrong, and if it can't be gotten as a string, then perl will be confused (and something is probably horribly wrong anyway). Additionally, our variable descriptions shoud be descriptive. Valid settings should not be NULL (and NULL is more likely indicative of forgetting to set it than actually wanting an empty valid set).
4:28 AM Changeset [eeba011] by Jason Gross <jgross@mit.edu>
Drop require_type It's not doing much for us (and would do even less after the next commit), and dropping it makes owl_variable_dict_newvar_* a bit more robust.
4:28 AM Changeset [3dfc083] by Jason Gross <jgross@mit.edu>
Refactored owl_variable_dict_newvar_* to give accurate validsettings, and cleanup better The cleanup no longer depends on the existing variable being the same type, and is more less likely to leak, in particular when the variables have custom delete functions. Variables created from perl now have the appropriate default validsettings.
12:38 AM Ticket #184 (Default zsigs are empty) created by jgross@mit.edu
Since commit 010a9511420887329269aa51e7598533e826c57f, the default …

Jun 26, 2011:

10:53 PM Changeset [705ea86] by Jason Gross <jgross@mit.edu>
AX_CHECK_FLAG: Fix to work with autoconf 2.59 • AS_VAR_PUSHDEF([FLAGS], [something containing FLAGS]) caused an infinite loop before v2.65~21. • AS_VAR_APPEND was new in v2.63b~224. • AS_VAR_IF was new in v2.63~27. • AS_ECHO was new in AUTOCONF-2.61a~45, and AC_PROG_GREP in AUTOCONF-2.59c~744, but their use here is more idiomatically replaced with a case pattern anyway. • Before AUTOCONF-2.60b~8, the variable name passed to AC_CACHE_CHECK, AS_VAR_GET, AS_VAR_SET, and AS_VAR_SET_IF must be left unquoted. Submitted upstream to https://savannah.gnu.org/patch/index.php?7563 . Signed-off-by: Anders Kaseorg <andersk@mit.edu>
7:37 PM Ticket #183 (Search should scroll through messages to match) created by jgross@mit.edu
If I search for a word that appears in the middle of a long message, …
12:40 AM Changeset [8fa8d0c] by GitHub Merge Button <merge-button@github.com>
Merge af562f50377925cac37704fd58ad0438060cc7fd into bad44968701bd819226d18137988f6234af2bcb4

Jun 25, 2011:

6:14 PM Changeset [af562f5] by Anders Kaseorg <andersk@mit.edu>
AX_CHECK_FLAG: Fix to work with autoconf 2.59 • AS_VAR_PUSHDEF([FLAGS], [something containing FLAGS]) caused an infinite loop before v2.65~21. • AS_VAR_APPEND was new in v2.63b~224. • AS_VAR_IF was new in v2.63~27. • AS_ECHO was new in AUTOCONF-2.61a~45, and AC_PROG_GREP in AUTOCONF-2.59c~744, but their use here is more idiomatically replaced with a case pattern anyway. • Before AUTOCONF-2.60b~8, the variable name passed to AC_CACHE_CHECK, AS_VAR_GET, AS_VAR_SET, and AS_VAR_SET_IF must be left unquoted. Submitted upstream to https://savannah.gnu.org/patch/index.php?7563 . Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:11 PM Changeset [1bdbcb1] by GitHub Merge Button <merge-button@github.com>
Merge 708837dc090b1b2239157de1d0aef4e269cf0e55 into bad44968701bd819226d18137988f6234af2bcb4
3:10 PM Changeset [708837d] by David Benjamin <davidben@mit.edu>
Revert "Replace obsolete AX_C_CHECK_FLAG with AX_CHECK_COMPILE_FLAG" This reverts commit f2a96c0fd0bab7380da67a9616eb04308488ff8f. It uses a macro AS_VAR_IF which is not available on some development environments we still support. (Entertainingly, AX_CHECK_COMPILE_FLAG itself only claims an AC_PREREQ of 2.59 which is probably a bug.)
1:17 PM Changeset [bad4496]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Reformat the man page to look more like others It doesn't look like anyone's actually consistent in man page formatting, but this looks decent. Also update it as it's rather stale in places.
1:17 PM Changeset [b8a3e00]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Consistently use BarnOwl or barnowl BarnOwl refers to the program, barnowl is the executable and any other identifiers that are conventionally lowercase.
10:01 AM Changeset [caac19d] by Jason Gross <jgross@mit.edu>
Improved ability to delete messages from perl BarnOwl::Message now has a delete_and_expunge command, and BarnOwl::queue_message returns the queued message, so that deletion actually works; there used to be no way to get the id of a queued message, and so ->delete() didn't actually do anything...
10:01 AM Changeset [67b959c] by Jason Gross <jgross@mit.edu>
Added a delete-and-expunge command. This command is analogous to the delete command, except that it also expunges only the {current,given} message. It also takes an optional --quiet parameter, because I plan to use it internally and don't want spew on success. Perhaps there's a better way to accomplish this... I couldn't figure out how the existing delete command is supposed to work internally. The logic behind the delete-and-expunge command is as follows: We always update both the message list and the display. So model the command that will do much of the work, owl_function_delete_and_expunge_message, off of owl_function_expunge. owl_function_delete_and_expunge_message takes one argument, which is the position of the item in the message list. It deletes it from the message list with a new function owl_messagelist_delete_and_expunge_element. This calls delete on the underlying owl_list, so the errors (if any) on an index that is too big might be unhelpful. owl_function_delete_and_expunge_cur and owl_function_delete_and_expunge_by_id both get the index of the relevant message (and a function owl_messagelist_get_index_by_id is added to messagelist.c to help the latter). They owl_function_error if no such message exists, and conditionally owl_function_makemsg on success.
9:51 AM Changeset [b2bfe1f] by Jason Gross <jgross@mit.edu>
Fixed a bug in the expunge command Expunging from past the end of the message list (e.g., the key strokes d > > x) no longer brings you to the first message. Additionally, the code in owl_function_expunge that is relevant to redisplaying after messages are removed from the message list was placed in helper functions, in preparation for the next commit.
7:22 AM Changeset [e1d3607] by GitHub Merge Button <merge-button@github.com>
Merge d9fbfd831d2af947f279310e5d92ba2dc15591af into 25891a81c52b4a7460682ef7a3773e6774e73e27
6:42 AM Changeset [16ce7a4] by GitHub Merge Button <merge-button@github.com>
Merge 25891a81c52b4a7460682ef7a3773e6774e73e27 into 650fb2c030491f5d6668ad439b83a6a6b7b9870e
6:42 AM Changeset [25891a8]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add a unit test for owl_history Also fix an off-by-one error in bounding the history size. May as well have those semantics be coherent and testable.
6:34 AM Changeset [d9fbfd8] by David Benjamin <davidben@mit.edu>
Reformat the man page to look more like others It doesn't look like anyone's actually consistent in man page formatting, but this looks decent. Also update it as it's rather stale in places.
6:03 AM Changeset [bc932fd] by GitHub Merge Button <merge-button@github.com>
Merge 650fb2c030491f5d6668ad439b83a6a6b7b9870e into 2560529186e398f85a038e8683d29058857eb7b7
5:46 AM Changeset [650fb2c]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Update autoconf macros from pkg-config Signed-off-by: Anders Kaseorg <andersk@mit.edu>
5:46 AM Changeset [378ede7]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Update autoconf macros from autoconf-archive Signed-off-by: Anders Kaseorg <andersk@mit.edu>
5:46 AM Changeset [f2a96c0]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Replace obsolete AX_C_CHECK_FLAG with AX_CHECK_COMPILE_FLAG Signed-off-by: Anders Kaseorg <andersk@mit.edu>
4:11 AM Changeset [d8e2f07] by GitHub Merge Button <merge-button@github.com>
Merge 2560529186e398f85a038e8683d29058857eb7b7 into 95b52d17a566adefc77f07749218fe0cb33a66b2
4:09 AM Changeset [2560529]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Consistently place function annotation at the beginning char CALLER_OWN * doesn't make a whole lot of sense.
3:26 AM Changeset [c266281]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove owl_list altogether All uses have been removed.
3:26 AM Changeset [ce68f23]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make owl_dict_get_keys return a GPtrArray Almost all the remaining uses of owl_list are tightly coupled into this one giant blob.
3:26 AM Changeset [3cdd6d2]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add owl_ptr_array_free convenience function Unfortunately, most uses of GPtrArray here require a two-step chant which is really annoying. Until we require glib 2.22 and get g_ptr_array_new_with_free_func, use this helper function.
3:26 AM Changeset [e4524da]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make aimsearch code use GPtrArray instead of owl_list
3:26 AM Changeset [ecffae6]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make owl_zephyr_get_anyone_list return a GPtrArray
3:26 AM Changeset [e6d7e4e]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace the puntlist with an GPtrArray
3:26 AM Changeset [eb897c6]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace owl_errqueue's owl_list with a GPtrArray
3:26 AM Changeset [7ed9bc6]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace owl_zbuddlist's owl_list with GPtrArray
3:26 AM Changeset [d191f45]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make owl_buddylist use a GPtrArray directly
3:26 AM Changeset [e4d7cb6]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace owl_keymap's list with a GPtrArray
3:26 AM Changeset [f9df2f0]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace owl_message's owl_list with a GPtrArray
3:26 AM Changeset [fc8a87a]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace owl_messagelist's internal owl_list with GPtrArray
3:26 AM Changeset [12294d2]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove owl_list from owl_zwrite Use a GPtrArray directly.
3:26 AM Changeset [6829afc]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Define CALLER_OWN macro Replace our exising uses of G_GNUC_WARN_UNUSED_RESULT with it. The old macro is just way too long. This also more clearly specifies the intent.
3:24 AM Changeset [95b52d1]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
history: Store history in a GQueue Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:24 AM Changeset [8e515f9]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
history: Do not deduplicate a partial entry This fixes a bug that let you to remove the last item from your history by typing it again, pressing up and down, and erasing it. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:24 AM Changeset [b470451]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
history: Tell owl_history_store whether the new entry will be partial Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:24 AM Changeset [ad37b39]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
history: Remove partial entries in owl_history_reset Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:24 AM Changeset [83a079a]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
history: Make owl_history_store also reset It doesn’t make sense to run owl_history_store without owl_history_reset (except in one case where we know the current position is already the beginning and we’re about to owl_history_set_partial), so let’s merge these functions. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:24 AM Changeset [9923144]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
history: Get rid of touched and associated bug This fixes the following bug: type a partial line, up, down, type the rest of the line, up, down; oops, we’re back to the first partial line. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:24 AM Changeset [43744ce]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
history: Remove unused repeats flag Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2:29 AM Changeset [1c01cdf7] by GitHub Merge Button <merge-button@github.com>
Merge 2bc6bb1631398bd9cd2eaeee9ed91c2a15649b30 into 8b293ea82bfdae7cddf0e0665ef6eca1cc0df04d
2:28 AM Changeset [2bc6bb16] by Anders Kaseorg <andersk@mit.edu>
history: Store history in a GQueue Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2:23 AM Changeset [32c331d] by Anders Kaseorg <andersk@mit.edu>
history: Do not deduplicate a partial entry This fixes a bug that let you to remove the last item from your history by typing it again, pressing up and down, and erasing it. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2:23 AM Changeset [7c80ea42] by Anders Kaseorg <andersk@mit.edu>
history: Tell owl_history_store whether the new entry will be partial Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2:22 AM Changeset [35849fe] by Anders Kaseorg <andersk@mit.edu>
history: Remove partial entries in owl_history_reset Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2:15 AM Changeset [413c910] by David Benjamin <davidben@mit.edu>
Consistently use BarnOwl or barnowl BarnOwl refers to the program, barnowl is the executable and any other identifiers that are conventionally lowercase.
2:12 AM Changeset [57a66fe] by Anders Kaseorg <andersk@mit.edu>
history: Make owl_history_store also reset It doesn’t make sense to run owl_history_store without owl_history_reset (except in one case where we know the current position is already the beginning and we’re about to owl_history_set_partial), so let’s merge these functions. Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Jun 24, 2011:

11:55 AM Changeset [8b293ea]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use glib spawn functions when launching a newmsgproc The glib version is smaller and has the advantage of not leaking all our file descriptors to the process. More importantly, it does not call malloc between fork and exec which is not safe in the presence of threads.

Jun 23, 2011:

10:48 PM Changeset [e458b63] by Edward Z. Yang <ezyang@mit.edu>
Remove extra spaces round parentheses. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
10:47 PM Changeset [4839f5a] by Edward Z. Yang <ezyang@mit.edu>
Rename zsig to permalink. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
10:44 PM Changeset [525dd8d] by Edward Z. Yang <ezyang@mit.edu>
Refine module setup process. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
10:27 PM Changeset [3d304b9] by Edward Z. Yang <ezyang@mit.edu>
Fix bug with removed get_topic comment. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>

Jun 22, 2011:

10:13 PM Changeset [26217b9] by GitHub Merge Button <merge-button@github.com>
Merge 2f6c2631acd6ec448d45e80dea7f3b2da7cc3f7c into b343c2c1248ccfcd8b514c26f4c896c1ec41888b
9:56 PM Changeset [2f6c263] by Edward Z. Yang <ezyang@mit.edu>
Improve docs, error handling and refactor. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [2c4c4c4] by Edward Z. Yang <ezyang@mit.edu>
Make topic detection more robust. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [68fa539] by Edward Z. Yang <ezyang@mit.edu>
Add autocomplete and wall-posting support. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [348cffc] by Edward Z. Yang <ezyang@mit.edu>
Suppress failed URL fetch errors. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [f134488] by Edward Z. Yang <ezyang@mit.edu>
Replace punctuation with spaces, and spaces to dashes, on rnjacob's suggestion. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [43d8a1e] by Edward Z. Yang <ezyang@mit.edu>
Note about async Facebook::Graph. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [6dccccf] by Edward Z. Yang <ezyang@mit.edu>
Suppress interest groups for now. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [303dbc1] by Edward Z. Yang <ezyang@mit.edu>
Add alternate implementation of keywords. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [6c3d4ad] by Edward Z. Yang <ezyang@mit.edu>
Rename postid to post_id. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [f4d1717] by Edward Z. Yang <ezyang@mit.edu>
Implement automatic instance selection, with no de-dup. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [2c8852a] by Edward Z. Yang <ezyang@mit.edu>
Add facebook-poll command and be more consistent about poll invoke. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [33a8d77] by Edward Z. Yang <ezyang@mit.edu>
Poll after comment. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [06bd0d1] by Edward Z. Yang <ezyang@mit.edu>
Make filters act more like traditional Zephyr filters. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [c323405] by Edward Z. Yang <ezyang@mit.edu>
Comment reading support and back-timing. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
9:56 PM Changeset [51ff997] by Edward Z. Yang <ezyang@mit.edu>
Initial commit of Facebook module implementation. This module was inspired by Kevin Riggle's Facebook-hacked-onto-Twitter implementation, but was rewritten to stand alone as its own module and use the new Facebook Graph API. It requires the Facebook::Graph CPAN module. Signed-off-by: Edward Z. Yang <ezyang@mit.edu>
3:45 PM Changeset [fc625fb] by GitHub Merge Button <merge-button@github.com>
Merge 6376af1d0990d3324261fd650a8d36af1195eacf into b343c2c1248ccfcd8b514c26f4c896c1ec41888b
3:43 PM Changeset [b343c2c]release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
_dirty_everything: Avoid argument-dropping function pointer cast Fixes “WARNING: While resolving call to function '_dirty_everything' arguments were dropped!” when building with clang LTO. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:40 PM Changeset [d427f08]release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Use G_GNUC_WARN_UNUSED_RESULT Have gcc warn us when we ignore the result of a function that requires the caller to free the result, or an initilization function that can fail. This might help (slightly) with preventing leaks and segfaults. Additionally changed some functions that should never fail to not return values. (The owl_list_* functions changed only fail if list->size < 0, which we assume is not the case elsewhere.)
3:36 AM Changeset [7086a20] by Anders Kaseorg <andersk@mit.edu>
history: Get rid of touched and associated bug This fixes the following bug: type a partial line, up, down, type the rest of the line, up, down; oops, we’re back to the first partial line. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
3:07 AM Changeset [87ab6e5] by Anders Kaseorg <andersk@mit.edu>
history: Remove unused repeats flag Signed-off-by: Anders Kaseorg <andersk@mit.edu>
12:37 AM Changeset [84a071f]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove global main_context variable It's really not necessary. We can pass NULL to g_main_loop_new to use the default context, and we don't reference the variable anywhere else.
12:37 AM Changeset [e146cd7]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove all uses of G_IO_PRI Any use of G_IO_PRI (and correspondingly OWL_IO_EXCEPT) is likely a bug as it's not really used for anything useful. The main use case is TCP out-of-band data which really isn't used by anyone. Reported-by: Anders Kaseorg <andersk@mit.edu>
12:37 AM Changeset [aa69c1e]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
And finally, remove owl_io_dispatch All uses have been replaced with a GIOChannel watch.
12:37 AM Changeset [2d04312]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use g_io_add_watch in zephyr initialization Which removes the final use of owl_io_dispatch.
12:37 AM Changeset [a6a9ddb]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace popexec's io_dispatch with a glib io watch Again, this code may be simplified with a GIOChannel.
12:37 AM Changeset [2244836]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use g_io_add_watch in the stderr redirect We may actually be able to put GIOChannel to good use here with g_io_channel_read_line.
12:37 AM Changeset [bbb7876]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace the stdin reader with a GIOChannel watch We ignore the channel itself as ncurses expects to do its own thing.
12:37 AM Changeset [bcde7926]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Reimplement BarnOwl::add_io_dispatch with AnyEvent We can emulate the interesting semantics with perl. The one difference is that perl code can now register an IO dispatch on file descriptors C code was interested in. This isn't a big deal was Glib can handle multiple watches on the same FD. Granted, more than one reader on an FD would cause trouble, but there was nothing stopping perl code from reading from an FD we cared about anyway. AnyEvent also does not support select's exceptfd, so this is a slight behavior change, but probably an uninteresting one.
12:37 AM Changeset [074bdaa]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace BarnOwl::Timer with a perl wrapper over AnyEvent This also allows us to kill owl_timer altogether.
12:37 AM Changeset [58f4fb2]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Drop show timers feature It was useful to access programmatically and probably not hugely useful. We can restore something like it later if it's really needed.
12:37 AM Changeset [72146c7]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Convert pseudologins timer to glib timers
12:37 AM Changeset [6b0b4f4]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Convert AIM timers to glib timers We do lose the timer tracking feature, but I think that's fine. Glib does have some main loop debug spew to run, though admittedly it may require a custom-built glib. Glib 2.14 allows us to use g_timeout_add_seconds which synchronizes wakeups at the seconds granularity to minimize CPU wakeups.
12:37 AM Changeset [4f746f8]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Bump required glib version to 2.16 Debian Lenny's version is 2.16.6-3 and Ubuntu Hardy's is 2.16.6-0ubuntu1.2. Also remove the version check in main; it never did anything useful as GLIB_CHECK_VERSION is evaluated at compile-time.
12:37 AM Changeset [9179fd7]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use AnyEvent's Glib backend

Jun 21, 2011:

11:19 PM Changeset [12505e3] by GitHub Merge Button <merge-button@github.com>
Merge f0d5ef52c48abd4954c21397e5fba9605d8f713f into 937a00e96102f86412b6844575901e57be238546
11:19 PM Changeset [f0d5ef5] by David Benjamin <davidben@mit.edu>
Remove global main_context variable It's really not necessary. We can pass NULL to g_main_loop_new to use the default context, and we don't reference the variable anywhere else.
11:19 PM Changeset [c66ec48] by David Benjamin <davidben@mit.edu>
Remove all uses of G_IO_PRI Any use of G_IO_PRI (and correspondingly OWL_IO_EXCEPT) is likely a bug as it's not really used for anything useful. The main use case is TCP out-of-band data which really isn't used by anyone. Reported-by: Anders Kaseorg <andersk@mit.edu>
11:19 PM Changeset [c5c5686] by David Benjamin <davidben@mit.edu>
And finally, remove owl_io_dispatch All uses have been replaced with a GIOChannel watch.
11:19 PM Changeset [b15f9e9] by David Benjamin <davidben@mit.edu>
Use g_io_add_watch in zephyr initialization Which removes the final use of owl_io_dispatch.
11:19 PM Changeset [b37accd] by David Benjamin <davidben@mit.edu>
Replace popexec's io_dispatch with a glib io watch Again, this code may be simplified with a GIOChannel.
11:19 PM Changeset [bdc53e0] by David Benjamin <davidben@mit.edu>
Use g_io_add_watch in the stderr redirect We may actually be able to put GIOChannel to good use here with g_io_channel_read_line.
11:19 PM Changeset [4da7659] by David Benjamin <davidben@mit.edu>
Replace the stdin reader with a GIOChannel watch We ignore the channel itself as ncurses expects to do its own thing.
11:19 PM Changeset [f21bc36] by David Benjamin <davidben@mit.edu>
Reimplement BarnOwl::add_io_dispatch with AnyEvent We can emulate the interesting semantics with perl. The one difference is that perl code can now register an IO dispatch on file descriptors C code was interested in. This isn't a big deal was Glib can handle multiple watches on the same FD. Granted, more than one reader on an FD would cause trouble, but there was nothing stopping perl code from reading from an FD we cared about anyway. AnyEvent also does not support select's exceptfd, so this is a slight behavior change, but probably an uninteresting one.
4:09 AM Changeset [c474a97] by Anders Kaseorg <andersk@mit.edu>
_dirty_everything: Avoid argument-dropping function pointer cast Fixes “WARNING: While resolving call to function '_dirty_everything' arguments were dropped!” when building with clang LTO. Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Jun 20, 2011:

10:26 PM Ticket #182 (update zcrypt man page to mention AES) created by geofft@mit.edu
The zcrypt man page should document the AES keyfile format. Once done, …

Jun 19, 2011:

10:24 PM Changeset [937a00e9]release-1.8release-1.9 by Alejandro R. Sedeño <asedeno@mit.edu>
Don't leak timestr when setting time in a perl message Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
4:40 AM Changeset [b0e6560] by GitHub Merge Button <merge-button@github.com>
Merge 7dfe886e75427ed8ba1ce9cc7e170bf1abd16b2c into 9d43dcc114c45fb1d94dec67eb38456bded0dc0d
2:44 AM Changeset [7dfe886] by Jason Gross <jgross@mit.edu>
Use G_GNUC_WARN_UNUSED_RESULT Have gcc warn us when we ignore the result of a function that requires the caller to free the result, or an initilization function that can fail. This might help (slightly) with preventing leaks and segfaults. Additionally changed some functions that should never fail to not return values. (The owl_list_* functions changed only fail if list->size < 0, which we assume is not the case elsewhere.)
1:49 AM Changeset [9d43dcc]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Build with -Wwrite-strings Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:49 AM Changeset [4e37d56]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_dict_regtest: Copy and free dict values Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:49 AM Changeset [9efc154]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
variables_to_init: Copy string literals This squashes the rest of the -Wwrite-strings warnings from temporarily storing string literals in char * fields. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:49 AM Changeset [9e86f6f]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
variables_to_init: Move into new function owl_variable_add_defaults Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:49 AM Changeset [117c21c]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
commands_to_init: Copy string literals This squashes a bunch of -Wwrite-strings warnings from temporarily storing string literals in char * fields. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:49 AM Changeset [aad166a]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
commands_to_init: Move into new function owl_cmd_add_defaults Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:49 AM Changeset [ea68035]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Copy and free pval_default for OWL_VARIABLE_STRING variables Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:12 AM Changeset [fcc0936] by GitHub Merge Button <merge-button@github.com>
Merge 4798b3653fae047b4c94e9ea07237195446b2991 into fe73d0c8bf42966a7f576c0ee9158753d7685592
1:08 AM Changeset [4798b36] by Anders Kaseorg <andersk@mit.edu>
Build with -Wwrite-strings Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:08 AM Changeset [81a5686] by Anders Kaseorg <andersk@mit.edu>
variables_to_init: Copy string literals This squashes the rest of the -Wwrite-strings warnings from temporarily storing string literals in char * fields. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:08 AM Changeset [3756803] by Anders Kaseorg <andersk@mit.edu>
variables_to_init: Move into new function owl_variable_add_defaults Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:08 AM Changeset [df7301c] by Anders Kaseorg <andersk@mit.edu>
commands_to_init: Copy string literals This squashes a bunch of -Wwrite-strings warnings from temporarily storing string literals in char * fields. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:08 AM Changeset [d4c3284] by Anders Kaseorg <andersk@mit.edu>
commands_to_init: Move into new function owl_cmd_add_defaults Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:08 AM Changeset [44dd092] by Anders Kaseorg <andersk@mit.edu>
Copy and free owl_variable.pval_default Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:07 AM Changeset [24a791f]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Make owl_variable.validsettings const char * Signed-off-by: Anders Kaseorg <andersk@mit.edu>
12:07 AM Changeset [fe73d0c]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Just require stdbool.h and tell ncurses to use it Now that Solaris' stdbool.h works for us, we may as well just require it. The preamble is repetitive and didn't actually work anyway. (It conflicts with ncurses' attempts to redefine bool when stdbool.h is unavailable or disabled.) We may need to add a different preamble later if we care about including these headers in C++ (Solaris has a C++-incompatible stdbool.h), but we can deal with that later.
12:07 AM Changeset [d1d68e0]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Build with C99 This allows (and even requires) us to use -D_XOPEN_SOURCE=600 on Solaris. It also makes the Solaris stdbool.h actually work.
12:07 AM Changeset [4f5e38f]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Properly discover things when /usr/athena != /usr On Solaris, by an accident of configure and krb5-config, we manage to discover libzephyr and libcom_err, but not com_err.h. Thankfully the latter is not fatal and we relied on C's defaulting everything to int. And by accident we were searching for libzephyr, and not zephyr.h. Also use CPPFLAGS instead of CFLAGS to pull in our bundled header files, otherwise autoconf warns about a discrepancy between the preprocessor and compiler.
12:07 AM Changeset [b14f8cb]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make the barnowl shell script work in Solaris Apparently their shell is lame. In case someone wanted to run this thing on Solaris or something absurd like that.
12:04 AM Changeset [a006d475] by GitHub Merge Button <merge-button@github.com>
Merge 28da2daf4548256b44d1fd586200032e96462d57 into e93dd785a2e76aa0dc14ecd56fd2c61b3598bc96

Jun 18, 2011:

11:56 PM Ticket #143 (jwrite fails on jids including a dash (-)) closed by jgross@mit.edu
fixed
11:52 PM Ticket #181 (Display jabber names (not just jids)) created by jgross@mit.edu
Currently, only jids are displayed on messages and notifications. We …
11:04 PM Ticket #172 (These tickets should go somewhere) closed by andersk@mit.edu
fixed
5:17 PM Ticket #149 (Net::IRC is abandoned) closed by davidben@mit.edu
fixed: Fixed in 1753ea0efc7c6af1bbd2888e6138421dbb939fad. Using AnyEvent::IRC now.
5:12 PM Changeset [0d3c100] by GitHub Merge Button <merge-button@github.com>
Merge e93dd785a2e76aa0dc14ecd56fd2c61b3598bc96 into 5b197f71370f5a5b3c3c09935c5679d6c90fa4c2
5:09 PM Changeset [e93dd78]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Properly tear down the ncurses screen in tester.c There's actually a set of valgrind suppressions in ncurses, and there really isn't API to clean up after initscr. But since we allocate this SCREEN ourselves, may as well clean it up.
5:07 PM Changeset [f0781ba]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Release reference to GMainLoop when done It's only done at shutdown, but we may as well appease valgrind.
4:39 PM Changeset [596c8b10]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't leak string data in owl_util_regtest
2:57 PM Changeset [a9237aa]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't specify both G_VOID and G_SCALAR Turns out G_SCALAR is 0, so it doesn't really matter, but we may as well say what we mean.

Jun 11, 2011:

10:16 PM Changeset [5b197f7]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
zcrypt: Remove unused #include <zephyr/zephyr.h> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
6:31 PM Changeset [7df7be2] by David Benjamin <davidben@mit.edu>
Replace BarnOwl::Timer with a perl wrapper over AnyEvent This also allows us to kill owl_timer altogether.
6:31 PM Changeset [b9d22f7] by David Benjamin <davidben@mit.edu>
Drop show timers feature It was useful to access programmatically and probably not hugely useful. We can restore something like it later if it's really needed.
6:31 PM Changeset [89fe67e] by David Benjamin <davidben@mit.edu>
Convert pseudologins timer to glib timers
6:31 PM Changeset [6dc3757] by David Benjamin <davidben@mit.edu>
Convert AIM timers to glib timers We do lose the timer tracking feature, but I think that's fine. Glib does have some main loop debug spew to run, though admittedly it may require a custom-built glib. Glib 2.14 allows us to use g_timeout_add_seconds which synchronizes wakeups at the seconds granularity to minimize CPU wakeups.
6:31 PM Changeset [db4f7c3] by David Benjamin <davidben@mit.edu>
Bump required glib version to 2.16 Debian Lenny's version is 2.16.6-3 and Ubuntu Hardy's is 2.16.6-0ubuntu1.2. Also remove the version check in main; it never did anything useful as GLIB_CHECK_VERSION is evaluated at compile-time.
6:31 PM Changeset [431fcd8] by David Benjamin <davidben@mit.edu>
Use AnyEvent's Glib backend
3:52 PM Changeset [2fe7c45]release-1.8release-1.9 by Karl Ramm <xyzzy-github@1ts.org>
Merge pull request #24 from ezyang/master Handle Jabber nicks with leading dashes (e.g. Facebook XMPP) Signed-off-by: Edward Z. Yang <ezyang@mit.edu> Reviewed-By: Karl Ramm <kcr@1ts.org>
10:04 AM Changeset [d6ab007] by GitHub Merge Button <merge-button@github.com>
Merge a27acf7e0eeeab9f58eed28146c6c99cc161b3b0 into 83a4af3422d232d9ef981a5a009e31549c839a14
9:35 AM Changeset [a27acf7]release-1.8release-1.9 by Edward Z. Yang <ezyang@mit.edu>
Handle Jabber nicks with leading dashes (e.g. Facebook XMPP) Signed-off-by: Edward Z. Yang <ezyang@mit.edu>

Jun 10, 2011:

7:06 PM Changeset [7f86e3d] by Anders Kaseorg <andersk@mit.edu>
zcrypt: Remove unused #include <zephyr/zephyr.h> Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Jun 6, 2011:

11:50 AM Changeset [28cd43f9] by GitHub Merge Button <merge-button@github.com>
Merge 83a4af3422d232d9ef981a5a009e31549c839a14 into cc305b53e93deb26ad26d3eb1beaf34d53c0d6ac

Jun 4, 2011:

5:55 AM Changeset [83a4af3]release-1.8release-1.9 by Jason Gross <jgross@mit.edu>
Replace free() with g_free() I can't believe I missed this when I made 950e2dac.

Jun 3, 2011:

11:07 PM Changeset [6376af1] by David Benjamin <davidben@mit.edu>
Use glib spawn functions when launching a newmsgproc The glib version is smaller and has the advantage of not leaking all our file descriptors to the process. More importantly, it does not call malloc between fork and exec which is not safe in the presence of threads.
Note: See TracTimeline for information about the timeline view.