Timeline


and

Mar 1, 2010:

8:33 PM Changeset [c4d1f12]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Add owl_buddy_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [5e8bec6]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Add owl_style_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [a96b109]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Add owl_message_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [d89c61f]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Add owl_cmd_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [3c0ec97]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_cmddict_execute: Don’t leak buffers when given no arguments. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [c8211b5]release-1.5 by Nelson Elhage <nelhage@mit.edu>
_owl_zephyr_process_events: Don’t leak ignored ZNotices. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [7306b0f]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_variable_enum_get_tostring: Don’t leak the tokenized settings. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [337f7d5]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_zcrypt_decrypt, owl_zcrypt_encrypt: Don’t leak the key filename. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [2d0de76]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_fmtext_appendf_normal: Don’t leak the formatted string to append. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [3959547]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_viewwin_init_fmtext: Don’t leak the temporary formatted text. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [5cebc0e]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_function_exec: Don’t leak the redirected command string. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8:33 PM Changeset [8ea0ffc]release-1.5 by Nelson Elhage <nelhage@mit.edu>
main: Don’t leak the default tty name. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [d836977c]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_command_zwrite, owl_command_zcrypt: Don’t leak an owl_zwrite on error. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [dd8340b]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_message_get_cc_without_recipient: Don’t overflow the output buffer. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [3d0a253]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_command_aimwrite: Fix a buffer overflow on aimwrite -m. I’ve tested that this works at least as well as the old code. There’s still something wrong here because aimwrite concatenates its arguments to get the screenname and aimwrite -m doesn’t, but I don’t care anymore because libfaim is going away (right? RIGHT?). Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Sam Hartman <hartmans@mit.edu>
8:33 PM Changeset [526f630]release-1.5 by Nelson Elhage <nelhage@mit.edu>
_owl_fmtext_curs_waddstr: Quash an uninitialized variable warning. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [97f85c3]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_zephyr_get_anyone_list: Fix a leak. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [67e5f4c9]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_util_file_deleteline: Fix a leak. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [212d8b7]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Don’t allocate 32 times as much memory as we need for decrypting. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [ccfa7d1]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Don’t read off the end of misaligned input messages. This fixes an input buffer overflow noticed by asedeno and andersk. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [19b2766]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Add tests. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [c4b5de8]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Don’t append a newline when decrypting. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [8fff19a]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Add separate functions for zcrypting with a particular key. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [54e1fe4]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Change zcrypt functions to allocate their output buffer. The logic to determine the right buffer size is complicated and does not belong in callers. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [b381b55]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Don’t leak the body after decrypting a message. This fixes a leak noticed by nelhage. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [b22170c]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Fix zcrypt when compiling without krb4 OpenSSL's "compatibility" DES API makes des_key_schedule a structure containing an array, while in krb4 it was an array directly. Thus, we need to pass a key schedule pointer to owl_zcrypt_string_to_schedule, instead of passing the key schedule by value. The compatibility macros defined in OpenSSL's des_old.h allow that function's passing of *schedule to des_key_sched() to DTRT. Reviewed-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [7d6a751]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Move cachedmsgid from owl_filter to owl_view. This fixes a use-after-free bug: owl_function_create_filter sets inuse=1, removes the current filter (hence freeing it), then calls owl_function_change_currentview_filter → owl_view_save_curmsgid → owl_filter_set_cachedmsgid, which writes to the filter that was just freed. This means that you can no longer keep two independent positions in two different filters by repeatedly switching between filter1 → empty → filter2 → empty → filter1. But I doubt anyone even knew that was possible before. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [7fd450f]release-1.5 by Nelson Elhage <nelhage@mit.edu>
perlglue.xs: Copy passed-in SV*s before storing them. Perl gives us a pointer to the same SV* that the caller was using, so if the caller mutates it in some way after the call, it affects our saved copy. This is definitely not what we want. Reported-by: William Throwe <wthrowe@MIT.EDU>
8:33 PM Changeset [65fca7a0]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Squelch an 'uninitialized' warning in recv:shift-left.
8:15 PM Changeset [80b5c42]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add owl_buddy_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [516c27e]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add owl_style_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [91634ec]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add owl_message_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [b0da027]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add owl_cmd_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [62a000b]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_cmddict_execute: Don’t leak buffers when given no arguments. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [46c7f5b]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
_owl_zephyr_process_events: Don’t leak ignored ZNotices. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [7a3a747]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_variable_enum_get_tostring: Don’t leak the tokenized settings. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [732cc15]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_zcrypt_decrypt, owl_zcrypt_encrypt: Don’t leak the key filename. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [1a01720]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_fmtext_appendf_normal: Don’t leak the formatted string to append. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [3e55268]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_viewwin_init_fmtext: Don’t leak the temporary formatted text. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [b85c1c4]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_function_exec: Don’t leak the redirected command string. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8:15 PM Changeset [1915073]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
main: Don’t leak the default tty name. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [1a0874f]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_command_zwrite, owl_command_zcrypt: Don’t leak an owl_zwrite on error. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
3:56 PM Ticket #131 (Segfault on malformed CC line) closed by andersk@mit.edu
fixed: Fixed in commit ce5d18124622414778781327150c74b8ed4206fb. Thanks for …
3:53 PM Changeset [ce5d181]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_message_get_cc_without_recipient: Don’t overflow the output buffer. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
2:01 PM Ticket #131 (Segfault on malformed CC line) created by cesium@mit.edu
If I send a zephyr where the first line is something like […] …

Feb 28, 2010:

9:55 PM Changeset [181ea08]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_command_aimwrite: Fix a buffer overflow on aimwrite -m. I’ve tested that this works at least as well as the old code. There’s still something wrong here because aimwrite concatenates its arguments to get the screenname and aimwrite -m doesn’t, but I don’t care anymore because libfaim is going away (right? RIGHT?). Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Sam Hartman <hartmans@mit.edu>
4:41 AM Ticket #130 (Use-after-free with pexec) created by andersk@mit.edu
On current master (18fb86e), valgrind detects this problem after …

Feb 25, 2010:

11:04 PM Changeset [18fb86ee]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
_owl_fmtext_curs_waddstr: Quash an uninitialized variable warning. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:58 PM Changeset [6b31006]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_zephyr_get_anyone_list: Fix a leak. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:58 PM Changeset [a61daae]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_util_file_deleteline: Fix a leak. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>

Feb 17, 2010:

1:31 PM Changeset [8789410]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Jabber: Mention [-a <account>] in :help jwrite. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>

Feb 9, 2010:

9:49 PM Changeset [f61e7ac]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
zcrypt: Don’t allocate 32 times as much memory as we need for decrypting. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
9:49 PM Changeset [1f37eba]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
zcrypt: Don’t read off the end of misaligned input messages. This fixes an input buffer overflow noticed by asedeno and andersk. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
9:49 PM Changeset [9be80b5]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
zcrypt: Add tests. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
9:49 PM Changeset [ae50abc]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
zcrypt: Don’t append a newline when decrypting. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
9:49 PM Changeset [a52eeb1]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
zcrypt: Add separate functions for zcrypting with a particular key. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
9:49 PM Changeset [dacb555]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
zcrypt: Change zcrypt functions to allocate their output buffer. The logic to determine the right buffer size is complicated and does not belong in callers. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
9:49 PM Changeset [d35d2ba]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
zcrypt: Don’t leak the body after decrypting a message. This fixes a leak noticed by nelhage. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
9:49 PM Changeset [3f18ad5]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Fix zcrypt when compiling without krb4 OpenSSL's "compatibility" DES API makes des_key_schedule a structure containing an array, while in krb4 it was an array directly. Thus, we need to pass a key schedule pointer to owl_zcrypt_string_to_schedule, instead of passing the key schedule by value. The compatibility macros defined in OpenSSL's des_old.h allow that function's passing of *schedule to des_key_sched() to DTRT. Reviewed-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>

Feb 6, 2010:

6:11 PM Changeset [9a023d0]release-1.10release-1.6release-1.7release-1.8release-1.9 by Geoffrey Thomas <geofft@mit.edu>
Send multiple PRIVMSGs for IRC messages entered as multiple paragraphs It is occasionally useful to be able to send multiple lines of IRC text at once, and I've grown used to barnowl's excellent support for composing long messages. As a compromise between allowing multiline IRC messages and not causing autowrap to send them inadvertently, send one IRC-level message (PRIVMSG or CTCP ACTION) for each two-newlines-separated paragraph in the user input to :irc-msg. Reviewed-by: Geoffrey Thomas <geofft@mit.edu>

Feb 5, 2010:

6:18 PM Ticket #129 (Appropriate handling of multiple AIM accounts) created by zhangc@mit.edu
":aimlogout" logs out all currently logged in AIM accounts, but what …

Feb 3, 2010:

5:05 PM Ticket #128 (No way to delete completions) created by broder@mit.edu
If I accidentally typo a class name (or anything else that gets …

Feb 2, 2010:

11:48 AM Ticket #127 (context bug with :eperl) created by nelhage@mit.edu
Using my DevelUtils plugin, run :eperl, and type something that has …

Feb 1, 2010:

2:20 PM Changeset [6249a76d]release-1.10release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Restore lost handle_message hook. This was accidentally deleted in commit 36546fa4ddc4de9c607b0f7bb76f8041360cf9f1 when we removed the mainloop hook.

Jan 30, 2010:

9:26 PM Changeset [c3a47c9]release-1.10release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Move cachedmsgid from owl_filter to owl_view. This fixes a use-after-free bug: owl_function_create_filter sets inuse=1, removes the current filter (hence freeing it), then calls owl_function_change_currentview_filter → owl_view_save_curmsgid → owl_filter_set_cachedmsgid, which writes to the filter that was just freed. This means that you can no longer keep two independent positions in two different filters by repeatedly switching between filter1 → empty → filter2 → empty → filter1. But I doubt anyone even knew that was possible before. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
7:07 PM Changeset [bdb7c26]release-1.10release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Only poll after posting if we're configured to.
Note: See TracTimeline for information about the timeline view.